Ticket #124 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

g_option_context_set_summary and BSDs

Reported by: tkg Assigned to:
Priority: minor Milestone: xmlroff 0.6.1
Component: libfo Version: 0.5.x
Keywords: Cc:
Blocking:

Description

From Asmodai:

The patch is threefold:

  1. Get rid of unused GOBJECT_CFLAGS and convert them to the proper GLIB_CFLAGS. They're required, since the files in those directories include glib includes.
  1. Get rid of end-of-file CFLAGS override. You were overriding the CFLAGS with GLIB_CFLAGS, which causes duplicate GLIB_CFLAGS later on in some cases. This way CFLAGS remains very pristine, reflecting only what the user or OS has passed along.
  1. Temporarily add GLIB_CFLAGS and GLIB_LIBS to CFLAGS and LIBS, after storing them in scratch variables. Restore them after testing.
  1. Add checks for /usr/local for CUnit. I seriously wonder if either autotools is just too stupid to automatically check /usr/local or whether I am missing something. (Also note that CUnit linking will break if CUnit was built with curses support, since we don't link to libcurses.) I get this on compilation at one point though: xmlroff/cunit/test-fo-doc.c:88: undefined reference to `fo_doc_gp_get_type'

It survives a clean build on my FreeBSD system (except for the CUnit stuff).

Attachments

configure.ac.diff (2.4 kB) - added by tkg on 07/09/08 22:40:37.
Diff from Asmodai.

Change History

07/09/08 22:40:37 changed by tkg

  • attachment configure.ac.diff added.

Diff from Asmodai.

09/24/08 18:00:14 changed by tkg

  • status changed from new to closed.
  • resolution set to fixed.

(In [504]) Corrected CFLAGS, etc., usage. (Closes #124, Asmodai.)